[PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

Ted Kremenek via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 21 22:11:47 PDT 2015


krememek added inline comments.

================
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749
@@ -748,3 @@
-
-  assert (Src != Dst && "Self-edges are not allowed.");
-
----------------
Did you look at the test case that causes this assertion to fail?  I think it would be good to know if this assertion is actually safe to remove.  I'm a bit skeptical that it is safe to remove, and that (per my last review) that this may be detecting that an invariant is getting violated.  If you are not certain how to investigate that part, please report which test is triggering the problem and myself or someone else familiar with the engine core can take a look.  Thanks.


http://reviews.llvm.org/D12119





More information about the cfe-commits mailing list