[PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

Naomi Musgrave via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 21 17:23:11 PDT 2015


nmusgrave added inline comments.

================
Comment at: lib/CodeGen/CGClass.cpp:1578
@@ +1577,3 @@
+        if (CGF.CGM.FieldHasTrivialDestructorBody(Context, Field) ||
+            Field->getType()->isPointerType()) {
+          // Start sanitizing at this field
----------------
eugenis wrote:
> Why do you need to special-case pointers?
FieldHasTrivialDestructorBody doesn't catch pointers- it identifies their base type as some class, and returns false


http://reviews.llvm.org/D12022





More information about the cfe-commits mailing list