[PATCH] D11194: Instantiate function declarations in instantiated functions.

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 20 14:21:16 PDT 2015


rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of tweaks. Thanks!


================
Comment at: lib/AST/DeclBase.cpp:276
@@ +275,3 @@
+      return false;
+    LDC = LDC->getParent();
+  } while (LDC);
----------------
`getLexicalParent()`?

================
Comment at: lib/AST/DeclBase.cpp:277-278
@@ +276,4 @@
+    LDC = LDC->getParent();
+  } while (LDC);
+  return false;
+}
----------------
I think we can actually recast this loop as `while (true)`, since we must eventually reach the TU and return false.


http://reviews.llvm.org/D11194





More information about the cfe-commits mailing list