[PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

Gábor Horváth via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 20 11:26:09 PDT 2015


xazax.hun added inline comments.

================
Comment at: lib/StaticAnalyzer/Core/CheckerManager.cpp:237
@@ +236,3 @@
+    return PreObjCMessageCheckers;
+    break;
+  case ObjCMessageVisitKind::Post:
----------------
nit: remove the break after the return.

================
Comment at: lib/StaticAnalyzer/Core/ExprEngineObjC.cpp:197
@@ +196,3 @@
+      // Generate a transition to non-Nil state, dropping any potential
+      // non-nil flow.
+      if (notNilState != State) {
----------------
Aren't we dropping the nil flow here instead of the non-nil? If that's the case, the comment should reflect that.


http://reviews.llvm.org/D12123





More information about the cfe-commits mailing list