[PATCH] D12002: Initial WebAssembly support in clang

[Dan Gohman via cfe-commits]

sunfish marked 2 inline comments as done.

================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:364
@@ +363,3 @@
+    ItaniumCXXABI(CGM, /* UseARMMethodPtrABI = */ true,
+                  /* UseARMGuardVarABI = */ true) {}
+
----------------
jfb wrote:
> It's more common to have no spaces for these comments: `/*UseARMMethodPtrABI=*/true,`.
Ok. I updated this in my local patch.

================
Comment at: lib/Driver/Tools.cpp:1567
@@ +1566,3 @@
+
+#ifdef __wasm__
+    // Handle "native" by examining the host.
----------------
jfb wrote:
> Could you expand a bit on why "native" doesn't make sense if LLVM itself wasn't compiled for wasm?
Ok. I added a comment to my local patch that says: "native" isn't meaningful when cross compiling, so only support this when the host is also WebAssembly.


Repository:
  rL LLVM

http://reviews.llvm.org/D12002