[PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

[Evgeniy Stepanov via cfe-commits]

eugenis added a comment.

The test for virtual base that you added effectively disables the aliasing test, because Derived now has non-trivial members.
Move it to a separate file.


================
Comment at: test/CodeGenCXX/sanitize-dtor-repress-aliasing.cpp:38
@@ +37,3 @@
+// Declaration of virtual function table
+// CHECK: $_ZTV7Derived = comdat any
+
----------------
I don't think this is interesting.


================
Comment at: test/CodeGenCXX/sanitize-dtor-repress-aliasing.cpp:47
@@ +46,3 @@
+// CHECK: ret void
+
+// CHECK-LABEL: define {{.*}}ZN7DerivedD0Ev
----------------
That's a lot of checks.
How about:
// CHECK-LABEL: define {{.*}}ZN7DerivedD1Ev
// CHECK-NOT: ret void
// CHECK: call void {{.*}}ZN7DerivedD2Ev
// CHECK-NOT: ret void
// CHECK: call void {{.*}}ZN11VirtualBaseD2Ev
// CHECK: ret void

And the same in ZN7DerivedD2Ev.
And remove all other destructors.



http://reviews.llvm.org/D12022