[PATCH] D9285: Add a KeepVirtual option to misc-use-override

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 18 11:04:47 PDT 2015


alexfh added a comment.

In http://reviews.llvm.org/D9285#224690, @ehsan wrote:

> Sorry, I kind of dropped the ball here!
>
> At Mozilla we ended up deciding on allowing only a maximum of one of virtual, final or override per function declaration, similar to the Google coding style, so we won't need the KeepVirtual option.  Should I still add it nevertheless?


No, I don't think the option (and the rule it backs up) makes sense. I'm glad you got rid of the relevant style rule ;)


http://reviews.llvm.org/D9285





More information about the cfe-commits mailing list