[PATCH] D11944: Nativize filename in FileManager::getFile().

[Sean Silva via cfe-commits]

On Thu, Aug 13, 2015 at 10:50 AM, Richard Smith via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> rsmith added a comment.
>
> I would think most Windows users would be surprised if we showed them
> paths with /s instead of \s, but I'm fine with us using / internally if it
> doesn't leak out to the user.
>

I think it makes sense to have a "canonical" form internally, similar to
how all our filesystem API's ensure that internally all of clang's buffers
are UTF-8.

-- Sean Silva


>
> klimek: if we want to nativize, I think the right thing to do is to remove
> the wrong "normalization" of non-Windows paths from
> `llvm::sys::path::native`, and add a more efficient overload to
> `llvm::sys::path::native`, such as `StringRef native(StringRef Input,
> SmallVectorImpl<char> &Buffer)`.
>
>
> http://reviews.llvm.org/D11944
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150817/023b6afa/attachment.html>