[PATCH] D12087: always_inline codegen rewrite

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 17 13:51:23 PDT 2015


rsmith added inline comments.

================
Comment at: lib/CodeGen/CodeGenModule.cpp:513
@@ +512,3 @@
+void CodeGenModule::RewriteAlwaysInlineFunctions() {
+  for (llvm::Function *Fn : AlwaysInlineFunctions)
+    RewriteAlwaysInlineFunction(Fn);
----------------
Does it matter that this traversal is nondeterministic? (Is the nondeterminism visible in the output IR?) Could you use a vector type for `AlwaysInlineFunctions`? (Does the same function ever actually get added to it twice?) If not, maybe a `SetVector` would be more appropriate.


http://reviews.llvm.org/D12087





More information about the cfe-commits mailing list