[PATCH] Fix crash with two typos in the arguments of a function

Olivier Goffart via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 17 03:39:37 PDT 2015


Hi,

Attached you will find the fix for a crash on invalid code in clang 3.7

It crashes on this code:

void fn2() {
  f(THIS_IS_AN_ERROR,  afunction(afunction_));  
}

The problem is that the arguments are of TheCall are reset later to the ones 
in Args. Some TypoExpr that have already been diagnosed will assert later in 
Sema::getTypoExprState.

I was wondering if instead of reusing the TheCall->getArgs() array I should 
copy the arguments in an array on the stack instead.

I suppose I should commit to trunk and ask someone to merge into release_37?

Regards
-- 
Olivier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-crash-with-two-typos-in-the-arguments-of-a-funct.patch
Type: text/x-patch
Size: 1691 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150817/6317ad08/attachment.bin>


More information about the cfe-commits mailing list