[PATCH] D10933: Add new IdentifierNaming check
Beren Minor via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 17 02:29:51 PDT 2015
berenm marked 2 inline comments as done.
================
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:166
@@ +165,3 @@
+ static llvm::Regex Splitter(
+ "(([a-z0-9A-Z]*)(_+)|([A-Z]?[a-z0-9]+)([A-Z]|$)|([A-Z]+)([A-Z]|$))");
+
----------------
alexfh wrote:
> Why do you need the outermost parentheses?
For some unknown reason, I always thought parentheses were required around regex alternation... Well, I now know they are not.
http://reviews.llvm.org/D10933
More information about the cfe-commits
mailing list