[PATCH] D12017: Fix IncludeInserter/IncludeSorter bug.

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 14 03:47:06 PDT 2015


klimek added inline comments.

================
Comment at: clang-tidy/IncludeSorter.cpp:144
@@ -138,3 +143,3 @@
   IncludeKinds NonEmptyKind = IK_InvalidInclude;
-  for (int i = IncludeKind - 1; i >= 0; --i) {
+  for (int i = IK_InvalidInclude - 1; i >= 0; --i) {
     if (!IncludeBucket[i].empty()) {
----------------
Add comment before this:

  // Find the non-empty include bucket to be sorted directly above 'IncludeKind'.
  // If such a bucket exists, we'll want to sort the include after that bucket.
  // If no such bucket exists, find the first non-empty include bucket in the file
  // In that case, we'll want to sort the include before that bucket.



http://reviews.llvm.org/D12017





More information about the cfe-commits mailing list