r244978 - Follow up r244975: The ctors of an abstract class don't need to be protected - the object isn't directly constructible/doesn't present a slicing risk

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 15:58:35 PDT 2015


Author: dblaikie
Date: Thu Aug 13 17:58:35 2015
New Revision: 244978

URL: http://llvm.org/viewvc/llvm-project?rev=244978&view=rev
Log:
Follow up r244975: The ctors of an abstract class don't need to be protected - the object isn't directly constructible/doesn't present a slicing risk

Modified:
    cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h

Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h?rev=244978&r1=244977&r2=244978&view=diff
==============================================================================
--- cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h (original)
+++ cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h Thu Aug 13 17:58:35 2015
@@ -651,12 +651,13 @@ private:
 
 class SymbolVisitor {
 protected:
+  ~SymbolVisitor() = default;
+
+public:
   SymbolVisitor() = default;
   SymbolVisitor(const SymbolVisitor &) = default;
   SymbolVisitor(SymbolVisitor &&) {}
-  ~SymbolVisitor() = default;
 
-public:
   /// \brief A visitor method invoked by ProgramStateManager::scanReachableSymbols.
   ///
   /// The method returns \c true if symbols should continue be scanned and \c




More information about the cfe-commits mailing list