[PATCH] D10365: Add cmd to compilation database file format

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 11:33:26 PDT 2015


klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.

LG with a happy path test.


================
Comment at: ../llvm/tools/clang/unittests/Tooling/CompilationDatabaseTest.cpp:45
@@ -41,1 +44,3 @@
+  expectFailure("[{\"directory\":\"\",\"arguments\":\"\",\"file\":\"\"}]", "Arguments not array");
+  expectFailure("[{\"directory\":\"\",\"command\":[],\"file\":\"\"}]", "Command not string");
 }
----------------
Please add a happy path test, too.


http://reviews.llvm.org/D10365





More information about the cfe-commits mailing list