[PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks

Ben Langmuir via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 10:20:53 PDT 2015


benlangmuir closed this revision.
benlangmuir added a comment.

Any regression to code completion was below the noise level in my testing.

r244912


================
Comment at: include/clang/Basic/Module.h:363
@@ +362,3 @@
+  /// This is more efficient than getFullModuleName().
+  bool fullModuleNameEqual(ArrayRef<StringRef> nameParts) const;
+
----------------
rsmith wrote:
> `fullModuleNameEquals` (extra 's' at the end) or `fullModuleNameIs` maybe?
I like fullModuleNameIs.


Repository:
  rL LLVM

http://reviews.llvm.org/D11403





More information about the cfe-commits mailing list