[PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.
Alexander Kornienko via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 13 08:40:05 PDT 2015
alexfh added inline comments.
================
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:87
@@ +86,3 @@
+ /// \brief Whether or not the parameter variable is referred only once in
+ /// the
+ /// given constructor.
----------------
nit: clang-format doesn't properly reflow comments, it just breaks long lines, so it sometimes needs manual cleanup (or gq in vim).
================
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:134
@@ +133,3 @@
+ : ClangTidyCheck(Name, Context),
+ IncludeStyle(StringSwitch<IncludeSorter::IncludeStyle>(
+ Options.get("IncludeStyle", "llvm") == "llvm" ?
----------------
Does this compile?
http://reviews.llvm.org/D11946
More information about the cfe-commits
mailing list