[PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 08:34:17 PDT 2015


alexfh added inline comments.

================
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:134
@@ +133,3 @@
+    : ClangTidyCheck(Name, Context),
+      IncludeStyle(StringSwitch<IncludeSorter::IncludeStyle>(
+                       Options.get("IncludeStyle", "llvm"))
----------------
Thinking a bit more of this, with just two values a conditional operator seems to be better than a StringSwitch.


http://reviews.llvm.org/D11946





More information about the cfe-commits mailing list