[PATCH] D11946: Create clang-tidy module modernize. Add pass-by-value check.
Alexander Kornienko via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 13 08:08:33 PDT 2015
alexfh added inline comments.
================
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:131
@@ +130,3 @@
+ : ClangTidyCheck(Name, Context) {
+ std::string IncludeStyleStr = Options.get("IncludeStyle", "llvm");
+ if (IncludeStyleStr == "llvm") {
----------------
alexfh wrote:
> Please use `llvm::StringSwitch`.
Also, please make `IncludeStyle` const and initialize it in the constructor initializer list.
http://reviews.llvm.org/D11946
More information about the cfe-commits
mailing list