[PATCH] D11944: Nativize filename in FileManager::getFile().

[Yaron Keren via cfe-commits]

yaron.keren added a comment.

I think she wishes your second option.

Note that windows API actually do accept slash as seperator and need no conversion.

  https://en.wikipedia.org/wiki/Path_(computing)#MS-DOS.2FMicrosoft_Windows_style

The issues are with apps that interpret slash as switch, mainly the VC toolchain and with humans that may expect to see backward slashes. Not all apps do. Windows ports of the gnu utils accept slash just fine, so both

  ls ../test
  ls ..\test

work running from cmd.exe. So lit tests can continue to use slash unless they call the real VC toolchain (in which case they can't run on non-Windows anyhow).

As for the humans, while it may make sense to backward-slash paths when printing diagnostics, the current output is a mix of whatever-was-used-as-input, slashes and backslahses depending on the code path so any standardization - slash or backslash - would be better.

Overall, this makes sense and will simplify code and tests.


http://reviews.llvm.org/D11944