[PATCH] D11944: Nativize filename in FileManager::getFile().

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 13 01:35:43 PDT 2015


klimek added a comment.

In http://reviews.llvm.org/D11944#222975, @rsmith wrote:

> In principle, normalizing slashes on Windows makes sense here. But we shouldn't use `llvm::sys::path::native`, because it's just too broken.


Ok, so if I understand you correctly it would make sense to create a normalize function for the file manager (it's all about the file manager's caching anyway).

The idea would be that on Windows we replace all / with \, otherwise we leave things as they are?


http://reviews.llvm.org/D11944





More information about the cfe-commits mailing list