[PATCH] D11963: Create a __config_site file to capture configuration decisions.

[Marshall Clow via cfe-commits]

mclow.lists added inline comments.

================
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
 #ifdef __GNUC__
----------------
espositofulvio wrote:
> mclow.lists wrote:
> > I'm reluctant to do this; because every include file slows down compilation - for every program that we compile.
> > 
> > However, this may be the right thing to do.
> I'm with Jonathan here, having config params dealt with this way it's easier and make things more manageable while the price of a slowdown, I think, shouldn't be substantial.
I just realized that this will complicate life for libc++ developers. Today, I can make a change in the checked-out directory, and test it by using `clang -I <path to libcxx>`.  Now, I'll have to actually build and install the headers some where to test.  [ Especially when testing against an installed compiler whose libc++ does not have a __config_site file ]

================
Comment at: test/std/atomics/libcpp-has-no-threads.pass.cpp:11
@@ -10,1 +10,3 @@
 
+#include <__config_site>
+
----------------
jroelofs wrote:
> mclow.lists wrote:
> > This is not the right include file. 
> > 
> > How about "#include <ciso646>", which defined in the standard (to do nothing), but includes "<__config>"
> > 
> > Really, this test doesn't belong in test/std/, but in test/libcxx, but this change didn't put it there.
> > 
> I think it'd be better for me to just move the test. What is <ciso646> supposed to be for?
The standard says that including it does nothing. :-)

It's a great file to include to get all the config information.



http://reviews.llvm.org/D11963