[PATCH] D10365: Add cmd to compilation database file format

[Manuel Klimek via cfe-commits]

klimek added a comment.

Ok, we're very close now :) Thanks for taking the time to work through this!


================
Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:299
@@ +298,3 @@
+        if (CommandFound) {
+          ErrorMessage = "Multiple command and arguments found";
+          return false;
----------------
Any reason we don't want to allow both, but prefer the arguments?

================
Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:302-304
@@ +301,5 @@
+        }
+        for (llvm::yaml::SequenceNode::iterator CI = SequenceString->begin(),
+          CE = SequenceString->end();
+          CI != CE; ++CI) {
+          SmallString<128> CommandStorage;
----------------
Can we use for-range loops with auto?


http://reviews.llvm.org/D10365