[PATCH] D11963: Create a __config_site file to capture configuration decisions.

Marshall Clow via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 11 21:28:43 PDT 2015


mclow.lists added inline comments.

================
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
 #ifdef __GNUC__
----------------
I'm reluctant to do this; because every include file slows down compilation - for every program that we compile.

However, this may be the right thing to do.

================
Comment at: test/std/atomics/libcpp-has-no-threads.pass.cpp:11
@@ -10,1 +10,3 @@
 
+#include <__config_site>
+
----------------
This is not the right include file. 

How about "#include <ciso646>", which defined in the standard (to do nothing), but includes "<__config>"

Really, this test doesn't belong in test/std/, but in test/libcxx, but this change didn't put it there.



http://reviews.llvm.org/D11963





More information about the cfe-commits mailing list