[PATCH] D11781: Refactored pthread usage in libcxx

Jonathan Roelofs via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 11 15:58:13 PDT 2015


jroelofs added inline comments.

================
Comment at: include/__config:744
@@ +743,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# ifndef _LIBCPP_THREAD_API
+#  error "No thread API"
----------------
The reason to use `CMAKE_BINARY_DIR` over `CMAKE_CURRENT_SOURCE_DIR` as the location for this build product is so that the source directory doesn't get polluted by builds.

Unfortunately that means that both libcxx and libcxxabi need to be pointed at the headers in the build directory, and not the ones from the source directory. 

I do have a pair of patches for this, which I'll post shortly.


Repository:
  rL LLVM

http://reviews.llvm.org/D11781





More information about the cfe-commits mailing list