r244670 - Fixing a few C++0x comments to be C++11; NFC.

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 11 14:52:12 PDT 2015


On Tue, Aug 11, 2015 at 5:47 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> On Tue, Aug 11, 2015 at 2:17 PM, Aaron Ballman via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
>>
>> Author: aaronballman
>> Date: Tue Aug 11 16:17:53 2015
>> New Revision: 244670
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244670&view=rev
>> Log:
>> Fixing a few C++0x comments to be C++11; NFC.
>
>
> Did you check whether these comments are still accurate when referencing the
> C++11 IS? The relevant paragraph is now p2 in the latest drafts, but I
> didn't check earlier ones. (C++0x was used in these comments rather than
> C++11 partly as a reminder to check that the references are still right when
> updating them.)

[class.copy]p3 is the correct reference in C++11.

~Aaron

>
>>
>> Modified:
>>     cfe/trunk/include/clang/AST/DeclCXX.h
>>
>> Modified: cfe/trunk/include/clang/AST/DeclCXX.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclCXX.h?rev=244670&r1=244669&r2=244670&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/AST/DeclCXX.h (original)
>> +++ cfe/trunk/include/clang/AST/DeclCXX.h Tue Aug 11 16:17:53 2015
>> @@ -2279,14 +2279,14 @@ public:
>>    }
>>
>>    /// \brief Determine whether this constructor is a move constructor
>> -  /// (C++0x [class.copy]p3), which can be used to move values of the
>> class.
>> +  /// (C++11 [class.copy]p3), which can be used to move values of the
>> class.
>>    ///
>>    /// \param TypeQuals If this constructor is a move constructor, will be
>> set
>>    /// to the type qualifiers on the referent of the first parameter's
>> type.
>>    bool isMoveConstructor(unsigned &TypeQuals) const;
>>
>>    /// \brief Determine whether this constructor is a move constructor
>> -  /// (C++0x [class.copy]p3), which can be used to move values of the
>> class.
>> +  /// (C++11 [class.copy]p3), which can be used to move values of the
>> class.
>>    bool isMoveConstructor() const {
>>      unsigned TypeQuals = 0;
>>      return isMoveConstructor(TypeQuals);
>> @@ -2396,7 +2396,7 @@ class CXXConversionDecl : public CXXMeth
>>    void anchor() override;
>>    /// Whether this conversion function declaration is marked
>>    /// "explicit", meaning that it can only be applied when the user
>> -  /// explicitly wrote a cast. This is a C++0x feature.
>> +  /// explicitly wrote a cast. This is a C++11 feature.
>>    bool IsExplicitSpecified : 1;
>>
>>    CXXConversionDecl(ASTContext &C, CXXRecordDecl *RD, SourceLocation
>> StartLoc,
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>


More information about the cfe-commits mailing list