[clang-tools-extra] r244597 - Do not use inheriting constructors.

[David Blaikie via cfe-commits]

Unsupported (which compiler(s)?) or just not preferred?
On Aug 11, 2015 6:00 AM, "Manuel Klimek via cfe-commits" <
cfe-commits at lists.llvm.org> wrote:

> Author: klimek
> Date: Tue Aug 11 07:59:22 2015
> New Revision: 244597
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244597&view=rev
> Log:
> Do not use inheriting constructors.
>
> Modified:
>     clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
>
> Modified:
> clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp?rev=244597&r1=244596&r2=244597&view=diff
>
> ==============================================================================
> --- clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
> (original)
> +++ clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
> Tue Aug 11 07:59:22 2015
> @@ -19,7 +19,8 @@ namespace {
>
>  class IncludeInserterCheckBase : public ClangTidyCheck {
>  public:
> -  using ClangTidyCheck::ClangTidyCheck;
> +  IncludeInserterCheckBase(StringRef CheckName, ClangTidyContext *Context)
> +      : ClangTidyCheck(CheckName, Context) {}
>    void registerPPCallbacks(CompilerInstance &Compiler) override {
>      Inserter.reset(new IncludeInserter(Compiler.getSourceManager(),
>                                         Compiler.getLangOpts(),
> @@ -54,14 +55,16 @@ public:
>
>  class NonSystemHeaderInserterCheck : public IncludeInserterCheckBase {
>  public:
> -  using IncludeInserterCheckBase::IncludeInserterCheckBase;
> +  NonSystemHeaderInserterCheck(StringRef CheckName, ClangTidyContext
> *Context)
> +      : IncludeInserterCheckBase(CheckName, Context) {}
>    StringRef HeaderToInclude() const override { return "path/to/header.h";
> }
>    bool IsAngledInclude() const override { return false; }
>  };
>
>  class CXXSystemIncludeInserterCheck : public IncludeInserterCheckBase {
>  public:
> -  using IncludeInserterCheckBase::IncludeInserterCheckBase;
> +  CXXSystemIncludeInserterCheck(StringRef CheckName, ClangTidyContext
> *Context)
> +      : IncludeInserterCheckBase(CheckName, Context) {}
>    StringRef HeaderToInclude() const override { return "set"; }
>    bool IsAngledInclude() const override { return true; }
>  };
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150811/f951a7c1/attachment.html>