[PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)
Антон Ярцев via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 11 06:08:37 PDT 2015
ayartsev added inline comments.
================
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:2359
@@ -2314,1 +2358,3 @@
+ RegionAndSymbolInvalidationTraits ITraits;
+ W.AddToWorkList(*I, ITraits);
}
----------------
Too much unnecessary passing around of RegionAndSymbolInvalidationTraits parameter. What about moving "RegionAndSymbolInvalidationTraits" member from "invalidateRegionsWorker" class to the base class "ClusterAnalysis"?
http://reviews.llvm.org/D11832
More information about the cfe-commits
mailing list