[PATCH] D11778: Improvements on Diagnostic in Macro Expansions

[Richard Trieu via cfe-commits]

rtrieu added a comment.

> There are still a lot of other cases in which my method still works as the old version did. 

>  And I think there are several bugs in the existing functions like "emitDiagnostic" and "mapDiagnosticRanges".

>  This is issued as a bug, the link is https://llvm.org/bugs/show_bug.cgi?id=24423.

>  Future work will be done to improve the current result.


The bug you linked to is a tracking bug for all macro improvements.  File bugs on specific examples you encounter and link it to that bug.


================
Comment at: test/Misc/reduced-diags-macros.cpp:14-15
@@ +13,4 @@
+// CHECK-NEXT: #define NO_INITIATION(x) int a = x * 2
+// CHECK-NEXT:                                  ^
+
+// CHECK: {{.*}}:7:15: error: use of undeclared identifier 'b'
----------------
zhengkai wrote:
> Yes.
> This works like the old version, should be improved later
File this issue as another bug.


http://reviews.llvm.org/D11778