[PATCH] D11781: Refactored pthread usage in libcxx

[Jonathan Roelofs via cfe-commits]

jroelofs added inline comments.

================
Comment at: include/__config:742
@@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# if defined(__FreeBSD__) || \
+    defined(__NetBSD__) || \
----------------
jroelofs wrote:
> @espositofulvio: @ed meant this:
> 
> ```
> #ifndef _WIN32
> #  include <unistd.h>
> #  if _POSIX_THREADS > 0
> ...
> #  endif
> #endif
> ```
> 
> Which //is// the correct way to test for this.
That being said, there have been discussions before about whether or not we should #include <unistd.h> in <__config>, with the conclusion being that we shouldn't.

It would be better if this were a CMake configure-time check that sets _LIBCPP_THREAD_API, rather than these build-time guards.


Repository:
  rL LLVM

http://reviews.llvm.org/D11781