[PATCH] D11824: Make target feature 'arm' cover both 32 and 64 bit architecutres

Ben Langmuir via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 6 16:49:51 PDT 2015


benlangmuir added inline comments.

================
Comment at: lib/Basic/Targets.cpp:4552
@@ -4551,2 +4551,3 @@
         .Case("arm", true)
+        .Case("aarch32", true)
         .Case("softfloat", SoftFloat)
----------------
rsmith wrote:
> Should we also recognize "arm32" to better mirror the 64-bit case?
Kristof convinced me it was better to stick with aarch32 since it had a defined meaning unlike arm32 (and unlike arm64 there is no compatibility or historical reason for it).


Repository:
  rL LLVM

http://reviews.llvm.org/D11824





More information about the cfe-commits mailing list