[PATCH] D8940: Clang changes for indirect call target profiling

Ivan Baev ibaev at codeaurora.org
Wed Aug 5 15:39:22 PDT 2015


ivanbaev added a subscriber: ivanbaev.

================
Comment at: lib/CodeGen/CodeGenPGO.cpp:858
@@ +857,3 @@
+  if (PGOReader && haveRegionCounts()) {
+    // We record the top most called five function at each call site.
+    // Profile metadata contains "indirect_call_targets" string identifying
----------------
davidxl wrote:
> 5 is too large as the default value. I suggest change the default to 2 targets and also make it controllable via an internal option.
3 is perhaps better; in the indirect call promotion pass we try to promote 2 targets, and it would be good to know what the hotness for the next target is.  


http://reviews.llvm.org/D8940





More information about the cfe-commits mailing list