[PATCH] D11761: [PATCH] clang-query quit command

[Manuel Klimek]

klimek added a comment.

Peter, any particular reason?

In http://reviews.llvm.org/D11761#218151, @aaron.ballman wrote:

> In http://reviews.llvm.org/D11761#218141, @pcc wrote:
>
> > I normally quit clang-query, or pretty much any other interactive command line program, by typing end-of-file (Ctrl-D on Unix, Ctrl-Z <enter> on Windows). If this works on Windows 10 I'd rather users do it that way. We can make this more discoverable through documentation.
>
>
> While Ctrl+Z <enter> does terminate clang-query on Windows, it's an incredibly obtuse way to terminate an interactive application on Windows. (Having used Windows for 20 years, I had to go look up what Ctrl+Z does!) Saying "but we can document it" doesn't really change that fact; users can already look at the documentation on MSDN to learn that Ctrl+Break or Ctrl+C will send a SIGINT (Ctrl+Z sets the EOF indicator, which is even more obtuse).
>
> I'm not certain that control codes to terminate interactive shell programs on Windows is as normal as it is on Unix-like systems.
>
> ~Aaron


+1 to that; I do think we want this to work well for windows users, and the expected knowledge is different


http://reviews.llvm.org/D11761