[PATCH] D11757: Propagate SourceLocations through to get a Loc on float_cast_overflow

[Alexey Samsonov]

samsonov added a comment.

Thank you for working on this! This change looks good to me, but I'll let Richard say a final word.

Note that you would need to make a corresponding change in UBSan compiler-rt runtime. Also, this is an ABI-breaking change - e.g. shared objects built with older Clang will not work properly with new runtime. I would recommend you to add *some* diagnostic to ubsan runtime - e.g. if it tries to read SourceLocation from FloatCastOverflowData passed to handler, but it looks more like TypeDescriptor, than it would crash with a verbose message.


http://reviews.llvm.org/D11757