[PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks

[Ben Langmuir]

benlangmuir updated this revision to Diff 31354.
benlangmuir added a comment.

Sorry for the slow response, I somehow missed your original comment.

Add a more cohesive comment.  I don't think we can usefully specify the SDK range it affects until a fixed SDK is available (currently it's every SDK that has module maps at all).  I'd love to update the comment then.  Ideally at that point we could also check the SDK version before applying the hack, but I'm not sure it's worth reading the SDK version plist file from disk just for that.  We already read this file when creating the module cache hash, but I'd like to remove that at some point.


Repository:
  rL LLVM

http://reviews.llvm.org/D11403

Files:
  include/clang/Basic/Module.h
  lib/Basic/Module.cpp
  lib/Lex/ModuleMap.cpp
  test/Modules/Inputs/System/usr/include/assert.h
  test/Modules/Inputs/System/usr/include/module.map
  test/Modules/Inputs/System/usr/include/tcl-private/header.h
  test/Modules/darwin_specific_modulemap_hacks.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11403.31354.patch
Type: text/x-patch
Size: 7943 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150805/bad4a829/attachment.bin>