[PATCH][Solaris] Clang/Driver, stop hardcoding GCC paths in crt/ld.so lookup

[Rafael Espíndola]

Please git-clang-format this patch.

+  // /usr/gcc/<major>.<minor>/lib/gcc/<major>.<minor>.<patch>/,

The code appends a triple after the "/lib/gcc". Is the comment missing it?

The inner loop has no version comparison. Are you depending on the
directory iteration order?

Can you add a testcase?

On 28 July 2015 at 12:35, Xan López <xan at igalia.com> wrote:
> Here it is.
>
> On Tue, Jul 28, 2015 at 01:21:06PM +0200, Xan López wrote:
>> On Tue, Jul 28, 2015 at 01:55:23PM +0300, Yaron Keren wrote:
>> > +cfe-commits
>> >
>> > This is a very large Solaris special case in ScanLibDirForGCCTriple which
>> > shares almost no code with the function.
>> > How about splitting it out to a helper function or
>> > making ScanLibDirForGCCTriple virtual and overriding on Solaris?
>>
>> Yep, at least a helper function makes sense, you are right. I'll send
>> another patch with either of those suggestions later today.
>>
>>
>> Xan
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>