[PATCH] D10847: Add missing atomic libcall support.

[Saleem Abdulrasool]

compnerd added a subscriber: compnerd.
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
This revision is now accepted and ready to land.

================
Comment at: lib/CodeGen/CGAtomic.cpp:788
@@ +787,3 @@
+    case AtomicExpr::AO__c11_atomic_init:
+      llvm_unreachable("Already handled!");
+
----------------
Can you make this a bit more useful by indicating where it should have been handled (Id assume Sema).

================
Comment at: lib/CodeGen/CGAtomic.cpp:811-815
@@ +810,7 @@
+
+    case AtomicExpr::AO__c11_atomic_load:
+    case AtomicExpr::AO__c11_atomic_store:
+    case AtomicExpr::AO__c11_atomic_exchange:
+    case AtomicExpr::AO__c11_atomic_compare_exchange_weak:
+    case AtomicExpr::AO__c11_atomic_compare_exchange_strong:
+    case AtomicExpr::AO__atomic_load_n:
----------------
jyknight wrote:
> majnemer wrote:
> > Do any of the tests cover this part of the change?
> None of the new ones do, but also note that this part is not a change in behavior, just changing from "default:" to listing all the options not listed above, so that missing a case emits a warning.
> 
> These calls are at least mostly covered by other tests, although I did not audit them to ensure 100% coverage.
> 
There are existing tests for the C11 atomics.

================
Comment at: lib/CodeGen/CGAtomic.cpp:846
@@ +845,3 @@
+    case AtomicExpr::AO__c11_atomic_init:
+      llvm_unreachable("Already handled!");
+
----------------
Similar.


http://reviews.llvm.org/D10847