[PATCH] D11279: Initial patch for PS4 toolchain

[Filipe Cabecinhas]

filcab marked an inline comment as done.

================
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:203-208
@@ +202,8 @@
+  InGroup<InvalidOrNonExistentDirectory>;
+def warn_drv_ps4_sdk_include : Warning<
+  "unable to find PS4 system headers directory, expected to be in '%0'">,
+  InGroup<InvalidOrNonExistentDirectory>;
+def warn_drv_ps4_sdk_lib : Warning<
+  "unable to find PS4 system libraries directory, expected to be in '%0'">,
+  InGroup<InvalidOrNonExistentDirectory>;
+
----------------
echristo wrote:
> Are the existing header warnings insufficient?
Yes. We have an expected location and would like the whole "PS4 SDK headers" thing in there.
But I can change it to be more general, like:

  def warn_drv_unable_find_directory_expected : Warning<
    "unable to find %0 directory, expected to be in '%1'">,
    InGroup<InvalidOrNonExistentDirectory>;

That might be preferable. That way other toolchains can use it (and we can merge the "libraries" and "headers" warnings.

================
Comment at: include/clang/Driver/Options.td:1159-1160
@@ -1158,2 +1158,4 @@
 def lazy__library : Separate<["-"], "lazy_library">, Flags<[LinkerInput]>;
+def linker : Separate<["-"], "linker">, HelpText<"Use linker <name>">, MetaVarName<"<name>">;
+def linker_EQ : Joined<["-"], "linker=">, Alias<linker>;
 def mlittle_endian : Flag<["-"], "mlittle-endian">, Flags<[DriverOption]>;
----------------
echristo wrote:
> Can this be done separately?
Created a diff: http://reviews.llvm.org/D11737


http://reviews.llvm.org/D11279