[PATCH] D11682: [libcxxabi] Add "install-libcxxabi" target.

Chris Bieneman beanz at apple.com
Mon Aug 3 09:46:01 PDT 2015


beanz added a comment.

In general I'd like a more generic solution, but I don't think we have the infrastructure for that yet, so I have no objection to the patches being done like this.

See my comment inline below for the one thing that needs to change.

Thanks,
-Chris


================
Comment at: src/CMakeLists.txt:123
@@ -124,1 +122,3 @@
+  LIBRARY DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi
+  ARCHIVE DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi
   )
----------------
You should not specify both ARCHIVE and LIBRARY in the same install command. One of the two will be ignored. As per the documentation (http://www.cmake.org/cmake/help/v3.0/command/install.html).

You will need to do something similar to what is done in AddLLVM.cmake:507-520.


http://reviews.llvm.org/D11682







More information about the cfe-commits mailing list