[PATCH] D11670: [libcxx] Disable -Wnon-virtual-dtor warning in <locale>

Eric Fiselier eric at efcs.ca
Thu Jul 30 22:05:23 PDT 2015


EricWF updated the summary for this revision.
EricWF updated this revision to Diff 31107.
EricWF added a comment.

David Blaikie pointed out that a better way to solve this warning is to make `__time_get_c_storage`'s destructor protected.


http://reviews.llvm.org/D11670

Files:
  include/locale

Index: include/locale
===================================================================
--- include/locale
+++ include/locale
@@ -1888,6 +1888,9 @@
     virtual const string_type& __r() const;
     virtual const string_type& __x() const;
     virtual const string_type& __X() const;
+
+    _LIBCPP_ALWAYS_INLINE
+    ~__time_get_c_storage() {}
 };
 
 template <class _CharT, class _InputIterator = istreambuf_iterator<_CharT> >


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11670.31107.patch
Type: text/x-patch
Size: 430 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150731/3526a7b8/attachment.bin>


More information about the cfe-commits mailing list