[PATCH] D11613: repress tail call optimization when performing use-after-dtor sanitization

[Naomi Musgrave]

nmusgrave marked an inline comment as done.

================
Comment at: cfe/trunk/test/CodeGenCXX/sanitize-dtor-tail-call.cpp:17
@@ +16,3 @@
+// CHECK-LABEL: define {{.*}}SimpleD2Ev
+// CHECK: {{\s*}}call void @__sanitizer_dtor_callback
+// CHECK-NOT: {{\s*}}call void @__sanitizer_dtor_callback
----------------
jroelofs wrote:
> I don't think this check verifies what you want it to verify... you need to order it like this:
> 
> 
> ```
> // CHECK-NOT: {{\s*}}tail call void @__sanitizer_dtor_callback
> // CHECK: {{\s*}}call void @__sanitizer_dtor_callback
> // CHECK-NOT: {{\s*}}call void @__sanitizer_dtor_callback
> ```
> 
> or better yet:
> 
> 
> ```
> // CHECK: {{^ +}}call void @__sanitizer_dtor_callback
> // CHECK-NOT: call void @__sanitizer_dtor_callback
> ```
The [[ http://reviews.llvm.org/rL243673 | final committed version ]] reflects your suggested changes. I'm not sure why they're not showing up here- I had some difficulty squashing my local commits into a single commit for the remote.


Repository:
  rL LLVM

http://reviews.llvm.org/D11613