[PATCH] D11308: [libcxx] Cleanup CMake configuration and integrate with LLVM

Dan Albert danalbert at google.com
Tue Jul 28 10:47:08 PDT 2015


danalbert added inline comments.

================
Comment at: CMakeLists.txt:64
@@ +63,3 @@
+# Target options --------------------------------------------------------------
+option(LIBCXX_BUILD_32_BITS "Build 32 bit libc++" OFF)
+set(LIBCXX_SYSROOT "" CACHE STRING "Use alternate sysroot.")
----------------
Nit: the other descriptions end with a period

================
Comment at: CMakeLists.txt:105
@@ +104,3 @@
+
+# Set LIBCXX_BUILD_32_BITS to LLVM_BUILD_32_BITS is on and check that
+# we can build with 32 bits
----------------
This sentence doesn't make sense. "Set foo to bar is on..." ?


http://reviews.llvm.org/D11308







More information about the cfe-commits mailing list