[libunwind] Proposal to merge patches for libc++abi to 3.7

Nick Kledzik kledzik at apple.com
Mon Jul 27 18:46:21 PDT 2015


> On Jul 27, 2015, at 6:36 PM, Hans Wennborg <hans at chromium.org> wrote:
> 
> Nick, Saleem: are these OK for merging to 3.7?
Fine with me.

-Nick

> 
> On Mon, Jul 27, 2015 at 4:55 PM, Logan Chien <tzuhsiang.chien at gmail.com> wrote:
>> Hi,
>> 
>>> Do we have a code owner for libunwind?
>> It seems not.
>> FYR, I remembered that kledzik@ contributed the initial code base to
>> libc++abi.  compnerd@ extracted libunwind from libc++abi.
>> 
>>> These commits don't seem to have reached cfe-commits. Does anyone know
>>> why?
>> I feel that this is related to the site configuration.  I observed this
>> after the spin-off of libunwind.
>> 
>>> Should r243147 also be merged?
>> Yes.  It will be a good to do so as well.
>> 
>> Sincerely,
>> Logan
>> 
>> On Tue, Jul 28, 2015 at 2:12 AM, Hans Wennborg <hans at chromium.org> wrote:
>>> 
>>> Sounds reasonable. I'm happy to merge, but also have a few questions:
>>> 
>>> Do we have a code owner for libunwind?
>>> 
>>> These commits don't seem to have reached cfe-commits. Does anyone know
>>> why?
>>> 
>>> Should r243147 also be merged?
>>> 
>>> Thanks,
>>> Hans
>>> 
>>> On Sun, Jul 26, 2015 at 1:46 PM, Chandler Carruth <chandlerc at google.com>
>>> wrote:
>>>> FWIW, I agree, this seems really important.
>>>> 
>>>> On Sun, Jul 26, 2015 at 8:54 AM Logan Chien <tzuhsiang.chien at gmail.com>
>>>> wrote:
>>>>> 
>>>>> Hi Hans and Nick,
>>>>> 
>>>>> I would like to propose to merge following patches to libunwind 3.7
>>>>> branch:
>>>>> 
>>>>> r242642: libunwind: Introduce __libunwind_config.h.
>>>>> r243073: unwind: Fix libc++abi and libgcc build.
>>>>> 
>>>>> We need these changes to build libc++abi with libgcc (without
>>>>> libunwind.so.)  IMO, this is an important fix that should be merged to
>>>>> 3.7
>>>>> release.
>>>>> 
>>>>> May you have a look?  Thanks for your help!
>>>>> 
>>>>> Sincerely,
>>>>> Logan
>> 
>> 





More information about the cfe-commits mailing list