[PATCH] D11504: Split -Wmicrosoft into many detailed warnings.

Aaron Ballman aaron at aaronballman.com
Mon Jul 27 11:19:59 PDT 2015


On Mon, Jul 27, 2015 at 2:09 PM, Nico Weber <thakis at chromium.org> wrote:
> thakis added a comment.
>
> In http://reviews.llvm.org/D11504#212667, @rnk wrote:
>
>> This feels too fine-grained to me, but I could be convinced either way. Someone somewhere will probably be thankful that they can turn off *just* -Wmicrosoft-void-pseudo-destructor. @majnemer, what do you think?
>
>
> Fairly fine-grained flags are consistent with the -Wgnu flags and clang's warning flags philosophy in general. Merging the ones you pointed out sounds good to me though.

I really like the fine-grained approach, FWIW, though I do agree with
merging the ones Reid pointed out.

~Aaron



More information about the cfe-commits mailing list