[PATCH] D11504: Split -Wmicrosoft into many detailed warnings.

Nico Weber thakis at chromium.org
Sat Jul 25 15:10:25 PDT 2015


thakis created this revision.
thakis added a reviewer: rnk.
thakis added a subscriber: cfe-commits.

-Wmicrosoft currently covers many different areas, some more useful than others.  Split it into many targeted flags, so that projects can choose to enable only a subset of these warnings.  This is also useful for incrementally fixing and turning on these warnings.

-Wno-microsoft still disables all these warnings, and -Wmicrosoft still enables them all.  After this change, it's possible to pass `-Wno-microsoft -Wmicrosoft-unqualified-friend` to only enable -Wmicrosoft-unqualified-friend, and `-Wmicrosoft -Wno-microsoft-unqualified-friend` to enable all other Microsoft warnings.

I put all the template-related warnings behind -Wmicrosoft-template; if that turns out to be too coarse we can make that finer later on. (In practice, I haven't seen the template-related warnings fire frequently.)

We might want to tweak -Wmicrosoft-enum-value in the future, it's the only of all of the -Wmicrosoft warnings that doesn't seem useful in practice.

http://reviews.llvm.org/D11504

Files:
  include/clang/Basic/DiagnosticGroups.td
  include/clang/Basic/DiagnosticLexKinds.td
  include/clang/Basic/DiagnosticParseKinds.td
  include/clang/Basic/DiagnosticSemaKinds.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11504.30637.patch
Type: text/x-patch
Size: 19515 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150725/f4c5205c/attachment.bin>


More information about the cfe-commits mailing list