[PATCH] D11446: For loop style fix

David Majnemer david.majnemer at gmail.com
Fri Jul 24 15:31:19 PDT 2015


majnemer added inline comments.

================
Comment at: lib/CodeGen/CGVTables.cpp:853
@@ -852,6 +852,3 @@
 
-  typedef std::vector<const CXXRecordDecl *>::const_iterator const_iterator;
-  for (const_iterator i = DeferredVTables.begin(),
-                      e = DeferredVTables.end(); i != e; ++i) {
-    const CXXRecordDecl *RD = *i;
+  for (const CXXRecordDecl *const RD : DeferredVTables)
     if (shouldEmitVTableAtEndOfTranslationUnit(*this, RD))
----------------
I don't think it is typical LLVM style to stick const in that position, looks pretty verbose.


http://reviews.llvm.org/D11446







More information about the cfe-commits mailing list