[PATCH] D11446: For loop style fix

Piotr Padlewski prazek at google.com
Wed Jul 22 19:09:44 PDT 2015


Prazek created this revision.
Prazek added a reviewer: rsmith.
Prazek added a subscriber: cfe-commits.

http://reviews.llvm.org/D11446

Files:
  lib/CodeGen/CGVTables.cpp

Index: lib/CodeGen/CGVTables.cpp
===================================================================
--- lib/CodeGen/CGVTables.cpp
+++ lib/CodeGen/CGVTables.cpp
@@ -187,12 +187,12 @@
 
   if (!Thunk.Return.isEmpty()) {
     // Fix up the returned value, if necessary.
-    for (llvm::Function::iterator I = Fn->begin(), E = Fn->end(); I != E; I++) {
-      llvm::Instruction *T = I->getTerminator();
+    for (auto &BasicBlock : *Fn) {
+      llvm::Instruction *T = BasicBlock.getTerminator();
       if (isa<llvm::ReturnInst>(T)) {
         RValue RV = RValue::get(T->getOperand(0));
         T->eraseFromParent();
-        Builder.SetInsertPoint(&*I);
+        Builder.SetInsertPoint(&BasicBlock);
         RV = PerformReturnAdjustment(*this, ResultType, RV, Thunk);
         Builder.CreateRet(RV.getScalarVal());
         break;
@@ -832,10 +832,7 @@
   size_t savedSize = DeferredVTables.size();
 #endif
 
-  typedef std::vector<const CXXRecordDecl *>::const_iterator const_iterator;
-  for (const_iterator i = DeferredVTables.begin(),
-                      e = DeferredVTables.end(); i != e; ++i) {
-    const CXXRecordDecl *RD = *i;
+  for (const auto &RD : DeferredVTables) {
     if (shouldEmitVTableAtEndOfTranslationUnit(*this, RD))
       VTables.GenerateClassData(RD);
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11446.30442.patch
Type: text/x-patch
Size: 1286 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150723/a5652a13/attachment.bin>


More information about the cfe-commits mailing list