[PATCH] D11441: Generating available_externally vtables for classes without inline virtual functions

[John McCall]

rjmccall added a comment.

Mostly looks fine.  One suggestion, though.


================
Comment at: lib/CodeGen/CGVTables.cpp:831
@@ -822,2 +830,3 @@
+
   return !CGM.getVTables().isVTableExternal(RD);
 }
----------------
Please do your query second; in practice, many v-tables are not external, meaning that your check will not need to be run.  Your check is actually pretty expensive when optimization is enabled because of the full walk scanning for inline functions.


http://reviews.llvm.org/D11441