[PATCH] D11148: [ARM] Implement -Wa, -mfpu and friends for assemblers

Reid Kleckner rnk at google.com
Wed Jul 22 10:36:09 PDT 2015


rnk added a comment.

Sorry for ignoring this. I looked at it, didn't like the approach, but couldn't think of a better one.

Here's a dumb idea: what if we alias -Wa,-mcpu= to -mcpu=? This would have the unintended side effect of making -Wa,-mcpu affect the CPU used for *compilation* in addition to assembly, but that seems like not a very big deal. If that's OK, it solves the whole getLastArg problem without complicating the driver C++ code.


================
Comment at: lib/Driver/Tools.cpp:536
@@ +535,3 @@
+    if (Value.startswith("-mcpu="))
+        CPU = Value.substr(6);
+    if (Value.startswith("-march="))
----------------
You probably want to clang-format the patch.


http://reviews.llvm.org/D11148







More information about the cfe-commits mailing list