[PATCH] D11300: Allow PenaltyBreakBeforeFirstCallParameter to not break Obj-C call before first parameter

Daniel Jasper djasper at google.com
Tue Jul 21 16:06:59 PDT 2015


djasper added inline comments.

================
Comment at: lib/Format/TokenAnnotator.cpp:1701
@@ -1700,2 +1700,3 @@
       return Style.PenaltyReturnTypeOnItsOwnLine;
-    return 200;
+    unsigned penalty = 200;
+    if(Right.is(TT_StartOfName)) {
----------------
I don't understand this change. Could you elaborate?

================
Comment at: unittests/Format/FormatTest.cpp:7343-7344
@@ +7342,4 @@
+
+  // TODO: logic in ContinuationIndenter::moveStatePastFakeLParens adds more
+  // spaces than expected to second line.
+  verifyFormat("[[self foo] function:\n"
----------------
No, this is exactly as many spaces as intended. It is 4 spaces from "function".


Repository:
  rL LLVM

http://reviews.llvm.org/D11300







More information about the cfe-commits mailing list