[PATCH] D11240: Add basic #include sorting functionality to clang-format
Daniel Jasper
djasper at google.com
Tue Jul 21 01:21:41 PDT 2015
djasper added inline comments.
================
Comment at: tools/clang-format/ClangFormat.cpp:277
@@ +276,3 @@
+ std::error_code EC;
+ raw_fd_ostream FileOut(FileName, EC, llvm::sys::fs::F_Text);
+ if (EC) {
----------------
That's exactly what the rewriter does. It simply doesn't help us at all in this case. Other than writing the file atomically, it only makes our life harder.
I think clang-format outputting the replacements in the order in which they need to applied makes sense and is significantly easier to integrate with than a two-phase run.
http://reviews.llvm.org/D11240
More information about the cfe-commits
mailing list